lib/logic-plugin-manager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(lib): setting nickname/shortname to None removes it properly
Some checks failed
Publish / run (push) Has been cancelled
Details

Browse Source
This commit is contained in:
h
2026-01-28 21:48:14 +01:00
parent 670f730085
commit d144fa61a0
3 changed files with 21 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pyproject.toml
View File

@@ -1,6 +1,6 @@
[project] [project]
name = "logic-plugin-manager" name = "logic-plugin-manager"
version = "1.0.0" version = "1.0.1"
description = "A utility for parsing and managing plugins in Logic Pro" description = "A utility for parsing and managing plugins in Logic Pro"
readme = "README.md" readme = "README.md"
authors = [ authors = [

12
src/logic_plugin_manager/components/audiocomponent.py
View File

@@ -234,11 +234,11 @@ class AudioComponent:
""" """
return hash(self.tags_id) return hash(self.tags_id)
def set_nickname(self, nickname: str) -> "AudioComponent": def set_nickname(self, nickname: str | None) -> "AudioComponent":
"""Set a custom nickname for this component. """Set or remove a custom nickname for this component.
Args: Args:
nickname: Custom nickname string. nickname: Custom nickname string, or None to remove the nickname.
Returns: Returns:
AudioComponent: Self for method chaining. AudioComponent: Self for method chaining.
@@ -252,11 +252,11 @@ class AudioComponent:
self.load() self.load()
return self return self
def set_shortname(self, shortname: str) -> "AudioComponent": def set_shortname(self, shortname: str | None) -> "AudioComponent":
"""Set a custom short name for this component. """Set or remove a custom short name for this component.
Args: Args:
shortname: Custom short name string. shortname: Custom short name string, or None to remove the short name.
Returns: Returns:
AudioComponent: Self for method chaining. AudioComponent: Self for method chaining.

18
src/logic_plugin_manager/tags/tagset.py
View File

@@ -107,11 +107,11 @@ class Tagset:
return self return self
def set_nickname(self, nickname: str): def set_nickname(self, nickname: str | None):
"""Set the nickname field in the tagset. """Set or remove the nickname field in the tagset.
Args: Args:
nickname: New nickname value. nickname: New nickname value, or None to remove the nickname.
Raises: Raises:
NonexistentTagsetError: If .tagset file doesn't exist (from load). NonexistentTagsetError: If .tagset file doesn't exist (from load).
@@ -119,15 +119,18 @@ class Tagset:
TagsetWriteError: If writing fails (from _write_plist). TagsetWriteError: If writing fails (from _write_plist).
""" """
self.load() self.load()
if nickname is None:
self.__raw_data.pop("nickname", None)
else:
self.__raw_data["nickname"] = nickname self.__raw_data["nickname"] = nickname
self._write_plist() self._write_plist()
self.load() self.load()
def set_shortname(self, shortname: str): def set_shortname(self, shortname: str | None):
"""Set the shortname field in the tagset. """Set or remove the shortname field in the tagset.
Args: Args:
shortname: New short name value. shortname: New short name value, or None to remove the short name.
Raises: Raises:
NonexistentTagsetError: If .tagset file doesn't exist (from load). NonexistentTagsetError: If .tagset file doesn't exist (from load).
@@ -135,6 +138,9 @@ class Tagset:
TagsetWriteError: If writing fails (from _write_plist). TagsetWriteError: If writing fails (from _write_plist).
""" """
self.load() self.load()
if shortname is None:
self.__raw_data.pop("shortname", None)
else:
self.__raw_data["shortname"] = shortname self.__raw_data["shortname"] = shortname
self._write_plist() self._write_plist()
self.load() self.load()